Updates from Rudolf Lai Toggle Comment Threads | Keyboard Shortcuts

  • Rudolf Lai 2:51 pm on August 13, 2009 Permalink  

    Looks like I am the last. Sorry for the … 

    Looks like I am the last. Sorry for the delay, but I am not settling for releasing sub-par work. This new patch is of course subject to bug hunting and further refinement between now and the GSoC deadline. I am still working on the documentation. Please patch it on a new rev. 11804 trunk, as it relies on the installation process to initialize some variables.
    I have changed the implementation of albums from using a new post_type to using taxonomies.
    Feature overview: you can add / edit / trash photos, add / edit / delete albums, make one album a child of another. Use /photo/ and /album/ permalinks to access the photos, e.g. /photo/ for photostream, /photo/16 for photo with ID 16; /album/gsoc-2009/meetings for the meetings album under gsoc 2009 album.

    Please do tell me if there are bugs. I will fix them ASAP. Thanks.

  • Rudolf Lai 3:56 am on August 5, 2009 Permalink  

    Okay, I have just finished porting the p… 

    Edit ii: Download the patch and try it out 🙂 its OK for rev. 11776 (i.e. trunk at this posting ) ( +1 in half a day, how efficient ) with a few hunks. Thank you Shane for point out my mistake. If anybody also downloaded the patch before 1600UTC, please re-download. Cheers.
    Okay, I have just finished porting the patch to rev. 11755. Complete with trash functions and a few bug fixed. Apparently its now 11775 on the trunk, so I will test whether my patch works for that too. Will be posting the patch in a few hours 🙂 Stay tuned.
    Edit: Also fixed something in the media library page that I have been doing wrongly all along.

    • Shane 3:15 pm on August 5, 2009 Permalink

      Looing for album.php file that you specify in menu.php. Everything else looks pretty good!

    • Gregory Cornelius (gcorne) 9:51 pm on August 6, 2009 Permalink

      Lot’s of hard work, but I don’t understand why you defined a new media library item type, photo. What if I wanted to have an image be part of an album and be used in the content of a page? Based on the behavior I am seeing, this is not possible.

      My suggestion would be to modify the album editor to allow for uploading images into the album directly in such a way that the images would still be a part of the main media library and able to be inserted into pages/posts from the editor individually.

      Two import features would be the ability to thumbnails for all of the images in the album, the ability to reorder them, add captions, etc…

      • Rudolf Lai 10:19 am on August 7, 2009 Permalink

        Adding a new post_type ‘photo’ allows WordPress to differentiate between a ‘photo’ and an ‘attachment’. You point is valid here though– users need a way to insert a single photo into a blog post ( which the patch now lacks. ) I will work on that. I plan to implement a photo shortcode, and a way to insert via the upload/insert series of modal windows ( much like what you would do when you insert an attachment ). Please do tell me if you have more ways / a better way to approach this.

        • Gregory Cornelius (gcorne) 3:06 pm on August 7, 2009 Permalink

          From the user perspective, you don’t insert attachments, you insert images, uploaded .pdfs and other documents, or audio/video. I think that the notion of an attachment more or less broke with the introduction of the media library 2.5. The underlying idea is that their is an association in the database between the media item and the page/post or other post_type the media item was inserted into. Right now the database schema is only capable of associating a media library item with a single post (the post the item was initially inserted into) by using the post_parent. This makes the notion of an attachment a lot less useful, because the media library listing only shows the first post that a file is attached to, not all of them. From this perspective when you are creating an album, you are not doing anything different. The user is attaching images to a post, although in this case the post is of a type: album. This is the main reason why I would suggest that you do not define a new post_type for photos.

          The deficiency is in the way WordPress handles associated a media library item with a post, which is one reason why the current Gallery functionality is basically useless as far as I am concerned.

          I think that you should seriously consider creating an album editor where all operations to populate the album and adjust components are handled from the editor. Actions that I should be able to take are:

          – Upload a new image
          – Add existing image
          – Remove image
          – Reorder images (ideally drag and drop)
          – Edit image
          – Edit album title
          – Edit description
          – Allow for new metaboxes to be added to editor (like the post editor) so plugins can add functionality

  • Rudolf Lai 4:56 am on July 31, 2009 Permalink  

    I was originally planning to release a n… 

    I was originally planning to release a new patch yesterday. In fact, I have already finished it. The new one comes with a better UI for manipulating the albums, several bug fixes, and an implementation of the [album id=] shortcode.
    Then I discovered that there is a major change in the trunk, namely the addition of the trash system. So my apologies, but the patch is now delayed. I am working on putting the trash functions in now.

  • Rudolf Lai 2:30 am on July 28, 2009 Permalink  

    Just curious, when you add things to the… 

    Just curious, when you add things to the core, do you guys tag it as @since 2.9? I tag it as @since GSOC 2009 but I want some opinion on this. Cheers

    • Beau 2:35 am on July 28, 2009 Permalink

      If/when something is added to core it should ideally be tagged with @since, yes. You should probably just leave it blank for now though, because even if your code is ready for the next version, a committer might not get to it in time (leading to incorrect information, which is worse than no information).

    • DD32 8:19 am on July 28, 2009 Permalink

      Have a look at some of the code in the admin, and it’ll be: “@since unknown” Another way would be to replace it with “@since gsoc-2009-unknown-version-REPLACE” or some similar value thats unique, Just to make it easy for a find/replace by the commiter. If you’ve only a few functions, leaving it as unknown is fine.. but if its a lot, and you’re writing the docs, just use a unique string

    • Rudolf Lai 11:27 am on July 28, 2009 Permalink

      Hey thanks for the reply guys. I guess the @since tag is not really for me then, since for any code changes Mark ( or for that matter, any committer ) can easily know via the .diff patch. I was documenting the new code today and I thought I should put the @since tag in for the sake of completion.
      P.S. I will issue a new patch soon.

  • Rudolf Lai 2:19 am on July 28, 2009 Permalink  

    This week I have been mainly sorting out… 

    This week I have been mainly sorting out the data sanitization issues, and cleaning up the code ( merging redundant functions etc. ) I have also been adding comments ( documentation ) to the code. The project has all the basic functionality at the moment, though there is still a lot of room for improvement and polishing. Good luck to the rest of your projects!

  • Rudolf Lai 5:30 am on July 18, 2009 Permalink  

    This week I have been packing and optimi… 

    This week I have been packing and optimizing my code. I have also completed coding the edit/delete/add/view functions for albums. I am currently working on album insert shortcodes, and a good way for plugins to filter what the shortcode returns.

    I have also drawn a few mockups for the photo manager plugin, which will be developed next.

  • Rudolf Lai 6:04 am on July 7, 2009 Permalink  


    Hey All,

    Edit II: Here is the patch. Apply it on a fresh copy of WordPress rev. 11691, run the setup, and you can play with the new features. Remember to enable  permalinks to see the nice URLs in effect. This is a working alpha, so please tell me when there is a bug somewhere. Several things are still missing. The code still needs to be optimized. But its working. Thanks!

    Edit: Okay… finished coding. Will take a break and do a final check of different parts of the code, then I will submit it here.

    I am nearly done coding a working alpha version of wordpress which can handle photos and photo albums. I will release the code soon, but probably a bit later than the 1900 UTC deadline. My apologies; I have just received my high school public examination results half an hour ago. These few days have been tense and I made minimal progress.

    Anyway. New functions and functionality:

    Front end:

    1. Viewing a particular photo via /photos/ or ?photo}{id}
    2. Viewing a particular album via /album/{id} or ?album={id}
    3. Viewing all photos via /photos/ or ?photostream=1
    4. Photo and Album templates in themes, photo.php and album.php
    5. Added nice permalinks for attachments /attachment/{id}. This will hope to replace ?attachment_id={id}

    Back end:

    1. Allows the user to set the base for photo URLs and album URLs. This creates the potential of turning wordpress into portfolio sites.
    2. Uploading files and setting them to be either a PHOTO or an non-post-specific attachment using flash and html upload methods.
    3. Added Photos tab in Media Library. Allows users to view, edit and delete photos.
    4. Allows the user to create albums.
    5. Allows the user to associate / dissociate a photo with multiple albums.

    Functions and functionality not yet implemented, but in development:

    1. .zip upload
    2. Searching Albums and Photos
    3. Deleting albums, as well as deleting photos from an album.
    4. Drag and Drop photo sorting interface
    5. Cosmetics



    • Noel Jackson 6:28 pm on July 6, 2009 Permalink

      Excited to see it! 🙂

    • Jake Spurlock 3:58 pm on July 7, 2009 Permalink

      I can’t wait to use this plugin, I literally have thousands of pictures on my sites…

      • Jake Spurlock 3:59 pm on July 7, 2009 Permalink

        Maybe more then Matt, ok… Maybe not. 😉

        • Rudolf Lai 10:17 pm on July 8, 2009 Permalink

          Please do tell me what happens when you add some many photos then. Especially when anything goes weird.

  • Rudolf Lai 1:48 pm on June 24, 2009 Permalink  

    The project is going ahead at maximum sp… 

    The project is going ahead at maximum speed. I have finished implementing front end features, and have been meddling with the backend interface for a while now. I am currently working on allowing the flash uploader to distinguish between normal uploads and photo uploads. Apart from that, the HTML uploader works fine – it will add uploads as photos or as attachments according to the user input.
    After I finish with the Flash uploader I will work on the .zip upload function.

    • Jane Wells 2:41 pm on July 3, 2009 Permalink

      Rudolf, what do you mean by “the difference between normal uploads and photo uploads”?

  • Rudolf Lai 9:34 am on June 10, 2009 Permalink  

    Hey all, from Dan’s and César’s post, … 

    Hey all, from Dan’s and César’s post, and my own observations, I think many of us have the problem between choosing to code our projects in our own way, or try to code it as close as how WordPress previously codes similar functions. What are everybody’s ( mentors or GSoCers alike ) approach / opinion to this?

    • Noel Jackson 8:47 am on June 12, 2009 Permalink

      I’d suggest trying to work on your code as much as possible while trying to keep the WordPress coding standards in mind. It’s always nice to have clean tidy code – but the project is first priority. Use your best judgement and try and remember that this code needs to be read and understood easily by 100’s of other people.

  • Rudolf Lai 4:46 pm on June 4, 2009 Permalink  

    Hey All, Sorry for not updating everyone… 

    Hey All,
    Sorry for not updating everyone on Wednesday. I was in the middle of hacking through the permalinks and templates. As you all know, you cannot really stop when you start to code.
    Anyway, as Mark has suggested, I have been working on the permalinks and adding template file recognitions. I have implemented several things:
    1. /photos/ and /?photostream=1 now point to the photostream, which basically shows all the photos of the blog.
    2. /album/ and /?album=id now point to an album. The system also recognizes album.php as the template file for displaying albums.
    3. /photos/id and /?photo=id now points to a photo. The system recognizes photo.php as the template for displaying a single photo.
    4. I also routed /attachment/id to /?attachment_id=id.
    See it in action: http://www.rudolflai.com/projects/wordpress/

    • Rudolf Lai 4:48 pm on June 4, 2009 Permalink

      By the way, tomorrow I will be finishing the album page, that is, when the user goes to /album/id the system will show all photos associated with that album.

Compose new post
Next post/Next comment
Previous post/Previous comment
Show/Hide comments
Go to top
Go to login
Show/Hide help
shift + esc